From d66dccd637618416f231c176df13ee7559374fff Mon Sep 17 00:00:00 2001
From: Kallesh B S <kalleshbs47@gmail.com>
Date: Wed, 30 Apr 2025 12:57:29 +0530
Subject: [PATCH] modified api

---
 manageFee.http                               | 2 +-
 src/mssql/param-table/param-table.service.ts | 7 ++++++-
 src/oracle/param-table/param-table.dto.ts    | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/manageFee.http b/manageFee.http
index 2c52e8f..1d8aecd 100644
--- a/manageFee.http
+++ b/manageFee.http
@@ -1,4 +1,4 @@
-GET http://localhost:3000/oracle/GetPreparerByClientid?p_spid=as&p_clientid=8
+GET http://localhost:3000/mssql/GetParamValues?P_PARAMTYPE=000&P_SPID=asdf
 
 ###
 
diff --git a/src/mssql/param-table/param-table.service.ts b/src/mssql/param-table/param-table.service.ts
index 0343fd7..2ee357d 100644
--- a/src/mssql/param-table/param-table.service.ts
+++ b/src/mssql/param-table/param-table.service.ts
@@ -17,10 +17,13 @@ export class ParamTableService {
 
     async GETPARAMVALUES(body: getParamValuesDTO) {
         const finalBody = {
-            P_SPID: body.P_SPID ? body.P_SPID : null,
+            P_SPID: body.P_SPID === 0 ? body.P_SPID : body.P_SPID ? body.P_SPID : null,
             P_PARAMTYPE: body.P_PARAMTYPE ? body.P_PARAMTYPE : null,
         };
 
+        console.log(finalBody);
+        
+
         let connection: Connection;
         try {
             connection = await this.mssqlDBService.getConnection();
@@ -60,6 +63,7 @@ export class ParamTableService {
     async CREATEPARAMRECORD(body: CreateParamRecordDTO) {
         let connection: Connection;
         try {
+            connection = await this.mssqlDBService.getConnection();
             const request = new Request(connection);
             request.input('P_SPID', mssql.Int, body.P_SPID);
             request.input('P_PARAMTYPE', mssql.VarChar(255), body.P_PARAMTYPE);
@@ -86,6 +90,7 @@ export class ParamTableService {
     async UPDATEPARAMRECORD(body: UpdateParamRecordDTO) {
         let connection: Connection;
         try {
+            connection = await this.mssqlDBService.getConnection();
             const request = new Request(connection);
             request.input('P_SPID', mssql.Int, body.P_SPID);
             request.input('P_PARAMID', mssql.Int, body.P_PARAMID);
diff --git a/src/oracle/param-table/param-table.dto.ts b/src/oracle/param-table/param-table.dto.ts
index 4bf016c..31d1d3e 100644
--- a/src/oracle/param-table/param-table.dto.ts
+++ b/src/oracle/param-table/param-table.dto.ts
@@ -122,9 +122,9 @@ export class UpdateParamRecordDTO {
 }
 
 export class getParamValuesDTO {
+  @Min(0, { message: 'Property P_SPID must be at least 0' })
   @IsInt({ message: 'Property P_SPID must be a whole number' })
   @IsNumber({}, { message: 'Property P_SPID must be a number' })
-  @Min(0, { message: 'Property P_SPID must be at least 0' })
   @Transform(({ value }) => Number(value))
   @IsOptional()
   P_SPID?: number;