diff --git a/src/dto/manage-clients/manage-clients-property.dto.ts b/src/dto/manage-clients/manage-clients-property.dto.ts index f94d961..deff5a9 100644 --- a/src/dto/manage-clients/manage-clients-property.dto.ts +++ b/src/dto/manage-clients/manage-clients-property.dto.ts @@ -29,6 +29,7 @@ export class CLIENT_CONTACTID_DTO { @Min(0, { message: 'Property P_CLIENTCONTACTID must be at least 0 or more' }) @IsInt({ message: 'Property P_CLIENTCONTACTID allows only whole numbers' }) @IsNumber({}, { message: 'Property P_CLIENTCONTACTID must be a number' }) + @Transform(({ value }) => Number(value)) @IsDefined({ message: 'Property P_CLIENTCONTACTID is required' }) P_CLIENTCONTACTID: number; } diff --git a/src/middleware/OriginCheck.middleware.ts b/src/middleware/OriginCheck.middleware.ts index 0261f32..eeae5e2 100644 --- a/src/middleware/OriginCheck.middleware.ts +++ b/src/middleware/OriginCheck.middleware.ts @@ -16,10 +16,10 @@ export class OriginCheckMiddleware implements NestMiddleware { req.headers['x-forwarded-for']?.toString().split(',')[0].trim() || req.socket.remoteAddress; - this.logger.warn(`Client IP: ${ip}`); - this.logger.warn(`User-Agent: ${req.headers['user-agent']}`); - this.logger.warn(`Origin: ${origin}`); - this.logger.warn(`Host: ${req.headers.host}`); + // this.logger.warn(`Client IP: ${ip}`); + // this.logger.warn(`User-Agent: ${req.headers['user-agent']}`); + // this.logger.warn(`Origin: ${origin}`); + // this.logger.warn(`Host: ${req.headers.host}`); // if (origin === allowedOrigin) { diff --git a/src/oracle/manage-clients/manage-clients.service.ts b/src/oracle/manage-clients/manage-clients.service.ts index 2dbb72e..0ecdb97 100644 --- a/src/oracle/manage-clients/manage-clients.service.ts +++ b/src/oracle/manage-clients/manage-clients.service.ts @@ -397,13 +397,13 @@ export class ManageClientsService { const result = await connection.execute( `BEGIN - MANAGEPREPARER_PKG.CreateClientContact( - :P_SPID, :P_CLIENTID, :P_USERID, :P_CURSOR + MANAGEPREPARER_PKG.SetDefaultClientContacts( + :P_SPID, :P_CLIENTCONTACTID, :P_USERID, :P_CURSOR ); END;`, { P_SPID: { val: body.P_SPID, type: oracledb.DB_TYPE_NUMBER }, - P_CLIENTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, + P_CLIENTCONTACTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, P_USERID: { val: body.P_USERID, type: oracledb.DB_TYPE_NVARCHAR }, P_CURSOR: { type: oracledb.CURSOR, dir: oracledb.BIND_OUT } }, @@ -441,13 +441,13 @@ export class ManageClientsService { const result = await connection.execute( `BEGIN - MANAGEPREPARER_PKG.CreateClientContact( - :P_SPID, :P_CLIENTID, :P_USERID, :P_CURSOR + MANAGEPREPARER_PKG.InactivateClientContacts( + :P_SPID, :P_CLIENTCONTACTID, :P_USERID, :P_CURSOR ); END;`, { P_SPID: { val: body.P_SPID, type: oracledb.DB_TYPE_NUMBER }, - P_CLIENTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, + P_CLIENTCONTACTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, P_USERID: { val: body.P_USERID, type: oracledb.DB_TYPE_NVARCHAR }, P_CURSOR: { type: oracledb.CURSOR, dir: oracledb.BIND_OUT } }, @@ -485,13 +485,13 @@ export class ManageClientsService { const result = await connection.execute( `BEGIN - MANAGEPREPARER_PKG.CreateClientContact( - :P_SPID, :P_CLIENTID, :P_USERID, :P_CURSOR + MANAGEPREPARER_PKG.ReactivateClientContacts( + :P_SPID, :P_CLIENTCONTACTID, :P_USERID, :P_CURSOR ); END;`, { P_SPID: { val: body.P_SPID, type: oracledb.DB_TYPE_NUMBER }, - P_CLIENTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, + P_CLIENTCONTACTID: { val: body.P_CLIENTCONTACTID, type: oracledb.DB_TYPE_NUMBER }, P_USERID: { val: body.P_USERID, type: oracledb.DB_TYPE_NVARCHAR }, P_CURSOR: { type: oracledb.CURSOR, dir: oracledb.BIND_OUT } }, diff --git a/src/oracle/user-maintenance/user-maintenance.service.ts b/src/oracle/user-maintenance/user-maintenance.service.ts index e76c728..cedafee 100644 --- a/src/oracle/user-maintenance/user-maintenance.service.ts +++ b/src/oracle/user-maintenance/user-maintenance.service.ts @@ -93,6 +93,8 @@ export class UserMaintenanceService { { outFormat: oracledb.OUT_FORMAT_OBJECT } ); + await connection.commit(); + const outBinds = result.outBinds; if (!outBinds?.P_CURSOR) { this.logger.error('One or more expected cursors are missing from stored procedure output.'); @@ -167,6 +169,8 @@ export class UserMaintenanceService { { outFormat: oracledb.OUT_FORMAT_OBJECT } ); + await connection.commit(); + const outBinds = result.outBinds; if (!outBinds?.P_CURSOR) { this.logger.error('One or more expected cursors are missing from stored procedure output.'); @@ -251,6 +255,8 @@ export class UserMaintenanceService { { outFormat: oracledb.OUT_FORMAT_OBJECT } ); + await connection.commit(); + const outBinds = result.outBinds; if (!outBinds?.P_CURSOR) { this.logger.error('One or more expected cursors are missing from stored procedure output.'); @@ -368,6 +374,8 @@ export class UserMaintenanceService { { outFormat: oracledb.OUT_FORMAT_OBJECT } ); + await connection.commit(); + const outBinds = result.outBinds; if (!outBinds?.P_CURSOR) { this.logger.error('One or more expected cursors are missing from stored procedure output.');